On recent master branch upgrade of an oldish 4.3 install, there were additional steps to take to address issues with call recording. Issue presents itself in that ext to ext calls, calls with parks and transfers, will not have recording accessible from CDR, but it is available in recordings dir.
Turns out that if upgrading inside the 4.3 branch, you should follow the extra steps in the 4.2 to 4.4 section of the docs. Note: that section is not with the upgrade instructions and is in at the bottom of the additional information section, so do keep an eye out.