Destinations duplicating on a fresh install

[voipBull]

Tried this on two fresh installs, FusionPBX master branch, just to rule out any config errors and same results. No new applications or mods installed after fresh install.

Added first inbound destination, and saved it. (Using fake numbers for demo, and leaving the ACTION blank - same results)



All is good until here.

Then added a second inbound destination.



As soon as you save the second destination number, and go back to the destinations menu, below is what you see. The first destination entry shows twice, and the second destination entry does not show at all.



Here, if you click on SHOW ALL, now you can see the two inbound destination entries.



If you switch back to the destinations menu, you again see the duplicated destination entries.

If you select the two duplicated entries and delete them both, then you see the second inbound destination entry added above.




Has anyone else come across this?

 

[voipBull]

Well, looks like its just a typo in a recent commit (6176ea2) to destinations.php

Line 244

foreach ($destinations as &$row) {

should be

foreach ($destinations as $row) {

 

[mcs3ss2]

@markjcrane

 

[whut]

Did you submit a pull request @voipBull ?

 

[voipBull]

@whut I only signed my CLA to be a contributor for the project yesterday after I found this issue. Waiting for the signed CLA pull request to be merged first.

 

[voipBull]

BTW, fixing the above typo in destinations.php fixes the duplication issue, but looks like there's another issue with Actions column as well. I see changes were made to actions function as well in the same commit (6176ea2).

 

[whut]

Oh no

 

[whut]

@voipBull @markjcrane I did some further digging. The `&$row` is causing the list of destinations to always display the last destination twice and you do not ever see the next to last destination. Hover and edit shows it is the same record displaying twice. If you change the sort order of the destinations you will see the wrong destinations changes because of which are the last 2.

removing `&` fixes this issue but then the actions are not displayed. You can see the action if you edit the action.

 

[markjcrane]

@whut I only signed my CLA to be a contributor for the project yesterday after I found this issue. Waiting for the signed CLA pull request to be merged first.

I accept CLA when a contributor has a pull request. Otherwise, we would have a lot of contributors in the list that don't contribute anything.

 

[markjcrane]

When this was reported to me last week I made the following changes on 6 May 2024.
- https://github.com/fusionpbx/fusionpbx/commit/8657a68d7ee574b9ac6cc550222a829ddf5ddab5

 

[voipBull]

Thank you @markjcrane