Bug deleting entries from dialplan FPBX v5.2.4

[iaindooley]

Hi there, my system status shows:

Version 5.2.4
Git Information Branch: 5.2
Commit: 16574221b1495ac156b1d482716083f6f21e2448
Origin: https://github.com/fusionpbx/fusionpbx
Status: Your branch is up to date with 'origin/5.2'. +73 days ago

The issue I'm reporting is that if you try to delete an entry from a dialplan, even though the line is removed from the interface after you click "Save", it remains in the XML until you click "Save" again. Screenshots below to reproduce:

Go into any diaplan, such as an inbound route and add an entry, then delete it by checking the "Delete" checkbox and clicking "Save":





The line is removed:



However if you click the "XML" button, you can see the entry is still present:



If you go back to the dialplan interface and do nothing other than click "Save", then click "XML" again, you will see the entry has been successfully removed:



Note that while it is in this state, that is it is gone from the interface, but present in the XML, it is still in effect during calls.

Thanks,
Iain

 

[markjcrane]

If you press save again it will read the current dialplan settings and remove the line from the XML.

 

[iaindooley]

Yes I know that's the bug I'm reporting

 

[markjcrane]

FusionPBX 5.3 is the current FusionPBX release. I just confirmed that this is not a problem on 5.3. This bug was fixed several months ago. The dialplan XML is deleted when the dialplan detail is deleted.

I remember fixing this bug it was several months ago. It's a good thing 5.3 was released and that you could upgrade to that version to fix this issue. Many bug fixes did get back ported to 5.2 but this one was a bigger change. The current 5.3 release is more stable and faster and looks better than the older 5.2 release.

 

[iaindooley]

Okay that's great thanks I'll take a snapshot and run the upgrade tonight.