Dialplan entry global-variables sanity check

Status
Not open for further replies.

Adrian Fretwell

Well-Known Member
Aug 13, 2017
1,498
413
83
Does anyone have a handle on what I think is a relatively new dialplan entry called global-variables. I'm pretty sure it has appeared in installations later that 9th January. The reason I ask it I'm seeing its action appearing repeatedly in the fs_cli. This test box only has five domains on it but I see this for a single inbound call:
Code:
EXECUTE [depth=0] sofia/external/01123456789@myprovider.co.uk set(RFC2822_DATE=Fri, 21 Feb 2020 13:59:52 +0000)
2020-02-21 13:59:52.406075 [DEBUG] mod_dptools.c:1672 SET sofia/external/01123456789@myprovider.co.uk [RFC2822_DATE]=[Fri, 21 Feb 2020 13:59:52 +0000]
EXECUTE [depth=0] sofia/external/01123456789@myprovider.co.uk set(RFC2822_DATE=Fri, 21 Feb 2020 13:59:52 +0000)
2020-02-21 13:59:52.406075 [DEBUG] mod_dptools.c:1672 SET sofia/external/01123456789@myprovider.co.uk [RFC2822_DATE]=[Fri, 21 Feb 2020 13:59:52 +0000]
EXECUTE [depth=0] sofia/external/01123456789@myprovider.co.uk set(RFC2822_DATE=Fri, 21 Feb 2020 13:59:52 +0000)
2020-02-21 13:59:52.406075 [DEBUG] mod_dptools.c:1672 SET sofia/external/01123456789@myprovider.co.uk [RFC2822_DATE]=[Fri, 21 Feb 2020 13:59:52 +0000]
EXECUTE [depth=0] sofia/external/01123456789@myprovider.co.uk set(RFC2822_DATE=Fri, 21 Feb 2020 13:59:52 +0000)
2020-02-21 13:59:52.406075 [DEBUG] mod_dptools.c:1672 SET sofia/external/01123456789@myprovider.co.uk [RFC2822_DATE]=[Fri, 21 Feb 2020 13:59:52 +0000]
EXECUTE [depth=0] sofia/external/01123456789@myprovider.co.uk set(RFC2822_DATE=Fri, 21 Feb 2020 13:59:52 +0000)
2020-02-21 13:59:52.406075 [DEBUG] mod_dptools.c:1672 SET sofia/external/01123456789@myprovider.co.uk [RFC2822_DATE]=[Fri, 21 Feb 2020 13:59:52 +0000]
EXECUTE [depth=0] sofia/external/01123456789@myprovider.co.uk set(RFC2822_DATE=Fri, 21 Feb 2020 13:59:52 +0000)
2020-02-21 13:59:52.406075 [DEBUG] mod_dptools.c:1672 SET sofia/external/01123456789@myprovider.co.uk [RFC2822_DATE]=[Fri, 21 Feb 2020 13:59:52 +0000]

global-variables is created for each domain, so its not technically global, but its context is set to ${domain_name}, something doesn't look right about this...
Screenshot from 2020-02-21 14-08-15.png
 

ad5ou

Active Member
Jun 12, 2018
892
204
43
I don't see this dial plan on my production server, but I do see it on a recent test server.

This seems like a bug where it should either be defined as either Global, or the context equals the actual domain name. I would assume it should be changed to "domain"="Global" and any duplicate dial plans should be removed.

The domain template file would also need to be modified to correct the bug. Sound like you should submit a bug report and/or a PR with corrections.
 
  • Like
Reactions: Adrian Fretwell

markjcrane

Active Member
Staff member
Jul 22, 2018
503
177
43
49
Posting bugs here makes them harder to find and not as likely to get fixed however I found this one and fixed the issue reported by original post.

p.s. "domain"="Global" this currently doesn't work but I have considered making it possible current global domains need a context of ${domain_name}
 

Adrian Fretwell

Well-Known Member
Aug 13, 2017
1,498
413
83
Posting bugs here makes them harder to find and not as likely to get fixed
Thankyou Mark. The post wasn't meant to be a bug report, just as it says, a sanity check for me. I have raised several other tickets as I'm sure you are aware. I know how busy you are currently an did not want to add to that workload with what could have been a "Nothing" report.

Cheers,
Adrian.
 

markjcrane

Active Member
Staff member
Jul 22, 2018
503
177
43
49
It turned out to be good thing because then it was brought to my attention and got fixed. Sorry I missed the 'sanity check' in the title... And I have noticed your other bug reports which will be worked on as time permits.

Thanks for bringing it up so it could be fixed.
 
  • Like
Reactions: Adrian Fretwell
Status
Not open for further replies.